Conversation
CUDALINK_LIB_PATH is retired (cuda_link resolution no longer uses an env var -- see cuda_link_bootstrap.py's layered lookup in the StreamDiffusionTD fork). CUDALINK_DOORBELL is still a live, installer-persisted var, so it exercises the same CUDALINK_ prefix allowlist path without asserting on a variable that no longer exists. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
forkni
force-pushed
the
fix/retire-cudalink-lib-path-env
branch
from
September 11, 2026 18:35
1126a05 to
e3f7e1a
Compare
Owner
|
Incorporated on Delivered source: c6cdba3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUDALINK_LIB_PATHis being retired:cuda_linkresolution no longer depends on anenv var. It's replaced by a layered lookup (explicit arg →
Basefolderpar → APPDATAstreamdiffusion_config.json→ plainimport cuda_linkoffsys.path) implemented incuda_link_bootstrap.pyon the StreamDiffusionTD side.This PR updates
tests/unit/test_diagnostics.pyso it no longer asserts on a variablethat's going away. It swaps the
CUDALINK_prefix-allowlist coverage over toCUDALINK_DOORBELL, which is a live, installer-persisted variable unrelated to librarypath resolution, so the same allowlist behavior is still exercised without depending on
the retired var.
diagnostics.pyitself needed no source change — itsCUDALINK_prefix match is generic.
Companion PRs (same root-cause fix, split by repo ownership)
CUDAIPCExtensioncompiles even whencuda_linkfails toimport (was the actual crash:
ModuleNotFoundError: No module named 'SHMProtocol'raised at class-body import time,
tdAttributeErroron every frame thereafter).cuda_link_bootstrap.pylayered resolver, dropsthe
CUDALINK_LIB_PATHdependency entirely.CUDALINK_LIB_PATHviasetx.Test plan
./venv/Scripts/python.exe -m pytest tests/unit/test_diagnostics.py— 29 passed./scripts/git/commit_enhanced.shlint/format gate passed on the changed file./scripts/git/push_validated.shpre-push lint passed (code lint clean; Markdownlint skipped via
--skip-md-lint— 424 pre-existing errors in unrelated filesSESSION_LOG.md,_hf_tracing_patches.md, two READMEs, none touched by this PR)🤖 Generated with Claude Code