Skip to content

test(diag): exercise CUDALINK_ prefix via CUDALINK_DOORBELL, not retired CUDALINK_LIB_PATH - #75

Closed
forkni wants to merge 1 commit into
dotsimulate:SDTD_040_beta_releasefrom
forkni:fix/retire-cudalink-lib-path-env
Closed

forkni wants to merge 1 commit into
dotsimulate:SDTD_040_beta_releasefrom
forkni:fix/retire-cudalink-lib-path-env

Conversation

@forkni

@forkni forkni commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

CUDALINK_LIB_PATH is being retired: cuda_link resolution no longer depends on an
env var. It's replaced by a layered lookup (explicit arg → Basefolder par → APPDATA
streamdiffusion_config.json → plain import cuda_link off sys.path) implemented in
cuda_link_bootstrap.py on the StreamDiffusionTD side.

This PR updates tests/unit/test_diagnostics.py so it no longer asserts on a variable
that's going away. It swaps the CUDALINK_ prefix-allowlist coverage over to
CUDALINK_DOORBELL, which is a live, installer-persisted variable unrelated to library
path resolution, so the same allowlist behavior is still exercised without depending on
the retired var. diagnostics.py itself needed no source change — its CUDALINK_
prefix match is generic.

Companion PRs (same root-cause fix, split by repo ownership)

Test plan

  • ./venv/Scripts/python.exe -m pytest tests/unit/test_diagnostics.py — 29 passed
  • ./scripts/git/commit_enhanced.sh lint/format gate passed on the changed file
  • ./scripts/git/push_validated.sh pre-push lint passed (code lint clean; Markdown
    lint skipped via --skip-md-lint — 424 pre-existing errors in unrelated files
    SESSION_LOG.md, _hf_tracing_patches.md, two READMEs, none touched by this PR)

🤖 Generated with Claude Code

CUDALINK_LIB_PATH is retired (cuda_link resolution no longer uses an
env var -- see cuda_link_bootstrap.py's layered lookup in the
StreamDiffusionTD fork). CUDALINK_DOORBELL is still a live,
installer-persisted var, so it exercises the same CUDALINK_ prefix
allowlist path without asserting on a variable that no longer exists.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@forkni
forkni force-pushed the fix/retire-cudalink-lib-path-env branch from 1126a05 to e3f7e1a Compare September 11, 2026 18:35
@dotsimulate

Copy link
Copy Markdown
Owner

Incorporated on sdtd041_dev. The diagnostics test now exercises the retained CUDALINK_DOORBELL variable and continues checking that unrelated secrets are excluded. Closing as incorporated on the intended development branch, without merging the original beta-based PR branch. Promotion to SDTD_040_stable is held for the operator release.

Delivered source: c6cdba3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants