Repository navigation
Remove retired PAT generator authentication guidance - #6802
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 64f49576-c7a0-4693-a798-19ce84e98975
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guidance-only deletions introduce no blocking issues; the requested draft author-review gate remains separate.
No open issues 🎉
What changed in this PR
Removes retired PAT generator guidance from DARC documentation and authentication editor help without changing authentication behavior.
Changes:
- Deletes the generator recommendation, command example, and seven-day lifetime statement.
- Preserves browser/device-code authentication and manual PAT alternatives.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Darc/Darc/Models/PopUps/AuthenticateEditorPopUp.cs | Removes obsolete generator guidance from editor help. |
| docs/Darc.md | Removes matching guidance from authentication documentation. |
Review effort: Balanced
premun
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the retired Azure DevOps PatGeneratorTool recommendation, command example, and seven-day lifetime statement from
docs/Darc.mdand thedarc authenticateeditor guidance.The generator was retired in dotnet/dnceng#6752. Continue recommending browser/device-code authentication and retain the existing manual PAT alternative, GitHub guidance, settings keys, token handling, and authentication behavior unchanged.
Tracking: AB#12217.
Validation
scripts/verify.ps1: full build succeeded. Darc tests: 188 passed, one skipped; DarcLib tests: 185 passed.git diff --checkpassed.dotnet run --project src/Microsoft.DotNet.Darc/Darc --no-build -- --helpdisplayed the actual Darc command list. It returned 1 through the existing parser's non-operation result path.PatGeneratororpat-generatorreferences.No new tests assert fixed help strings; this change removes obsolete guidance without changing authentication logic. Keep this PR in draft for author review. Merge and applicable mirror/VMR propagation remain outstanding; this PR does not close the tracking item by itself.