[SBC-4238] Windows Example - #28
Open
stedra-apryse wants to merge 31 commits into
Open
Conversation
kyrylo-volkov-apryse
requested changes
Jun 11, 2026
kyrylo-volkov-apryse
approved these changes
Jun 12, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…in print functions
kyrylo-volkov-apryse
requested changes
Sep 11, 2026
| fprintf(stdout, " %zu) %s\n", i + 1, text); | ||
| scanbotsdk_barcode_item_get_text(barcodes[i], &text_ref); | ||
| const char *text = scanbotsdk_u8string_ref_assume_cstring(text_ref); | ||
| fprintf(stdout, " %zu) %s\n", i + 1, text ? text : ""); |
There was a problem hiding this comment.
I think nullptr is impossible here, was text ever null in your tests?
| System.out.println("Detected points: " + detectionResult.getPoints().size()); | ||
|
|
||
| try (ImageRef cropped = processor.crop(image, detectionResult.getPointsNormalized())) { | ||
| try (ImageRef cropped = processor.crop(image, detectionResult.getPointsNormalized(), null)) { |
There was a problem hiding this comment.
Doesn't it fail here? You should pass valid value of the enum here, not null
| "nvvidconv flip-method=0 ! " | ||
| "video/x-raw, format=(string)BGRx ! " | ||
| "videoconvert ! video/x-raw, format=(string)BGR ! appsink drop=1" | ||
| "videoconvert ! " |
There was a problem hiding this comment.
Are all the changes in this file needed because of windows? Have you checked that linux and jetson still work?
|
|
||
| scanbotsdk_document_straightening_result_t *result = NULL; | ||
| scanbotsdk_document_straightening_parameters_t *straightening_params = NULL; | ||
| scanbotsdk_document_straightener_t *straightener = NULL; |
There was a problem hiding this comment.
File should be renamed as well. Same for other platforms
| python main.py scan <subcommand> --file <path/to/file.jpg> [--license <KEY>] | ||
| python main.py analyze <subcommand> --file <path/to/file.jpg> [--save <out.jpg>] [--license <KEY>] | ||
| python main.py classify <subcommand> --file|--resource <path/to/file.jpg> [--license <KEY>] | ||
| python main.py enhance <subcommand> --file <path/to/file.jpg> [--license <KEY>] |
There was a problem hiding this comment.
Probably straighten, same on other platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.