Skip to content
This repository was archived by the owner on Apr 2, 2020. It is now read-only.
This repository was archived by the owner on Apr 2, 2020. It is now read-only.

CSS fallback appears to require a filename match betwee head and config #66

Description

@guyaparker

It appears to me that CSS fallback requires that the filename specified in the config exactly matches the filename loaded in the head. If it does not then both stylesheets will be loaded irrespective of a match based on the exports config.

So, this will cause a request for both bootstrap.min.css and bootstrap.css:

<link href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.0/css/bootstrap.min.css" rel="stylesheet" type="text/css"/>
...
'libs': {
  'css$bootstrap': {
    'exports': '.col-xs-12',
   'urls': '//maxcdn.bootstrapcdn.com/bootstrap/3.3.0/css/bootstrap'
  }
}

But this will only request a bootstrap.min.css once:

<link href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.0/css/bootstrap.min.css" rel="stylesheet" type="text/css"/>
...
'libs': {
  'css$bootstrap': {
    'exports': '.col-xs-12',
   'urls': '//maxcdn.bootstrapcdn.com/bootstrap/3.3.0/css/bootstrap.min'
  }
}

If that is intentional I think it would benefit form being made clear in an example

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions