Repository navigation
Use github.com/dogmatiq/protobuf for Dogma's Protocol Buffers schema - #188
Merged
Merged
Conversation
The `uuidpb`, `identitypb`, `envelopepb` and `messaginggrpc` packages are removed in favor of those in `github.com/dogmatiq/protobuf`. The packers move to the new `envelope` package, and the UUID map and set move to the new `uuidcollection` package. `configpb` and `configgrpc` remain, regenerated to import the new schema. The command executor API and its error details are removed until they land in `github.com/dogmatiq/protobuf`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The packers now validate headers, bodies and messages directly, and the extension and baggage options use `envelopepb.SetExtension()` and `SetBaggage()`, so the matching rules aren't duplicated here. As a result, these options now panic on a nil pointer instead of packing it as an empty message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Dogma's shared schema out of enginekit and onto
github.com/dogmatiq/protobufv0.2.0.Removed
protobuf/uuidpb,protobuf/identitypbandprotobuf/envelopepb. Use the packages of the same name ingithub.com/dogmatiq/protobufinstead.grpc/messaginggrpc, includingCommandExecutorAPIand its error details. The event stream API is ingithub.com/dogmatiq/protobuf/messaginggrpc. The command executor will be added to a future version of that module.Added
envelopepackage:Packer,EffectPacker,Unpack()and the packing options, moved fromenvelopepb.uuidcollectionpackage:Map,SetandNewSet(), moved fromuuidpb.Changed
configpbandconfiggrpcare regenerated to import the new schema.dogma.protobuf.v1proto package instead ofdogma.protobuf. Their full names andAnytype URLs change, but their binary encoding is the same.envelope.WithExtension()andWithBaggage()now panic on a nil pointer, matchingenvelopepb.SetExtension().Downstream
uuidpbfromgithub.com/dogmatiq/protobufprojectionkit#972 can be merged and released before this. It doesn't depend on it.uuidpbfromgithub.com/dogmatiq/protobuftestkit#487 depends on this. It's a draft until this is released.🤖 Generated with Claude Code