Skip to content

fix: defer Herdr away injection without atomic admission - #84

Open
pranaypratyush wants to merge 1 commit into
dnth:mainfrom
pranaypratyush:fm/fm-herdr-away-admission-clean-replacement
Open

fix: defer Herdr away injection without atomic admission#84
pranaypratyush wants to merge 1 commit into
dnth:mainfrom
pranaypratyush:fm/fm-herdr-away-admission-clean-replacement

Conversation

@pranaypratyush

Copy link
Copy Markdown

Summary

  • Defer Herdr away-mode delivery whenever the backend cannot atomically admit a confirmed-empty composer and submit the digest.
  • Preserve the escalation buffer and human draft; never use a generic compare/send fallback for Herdr.
  • Cover the race deterministically and in a named non-default Herdr lab.

Validation

  • tests/fm-daemon.test.sh
  • tests/fm-backend-herdr.test.sh
  • HERDR_LAB_HELPER=/home/pranay/wd/firstmate/bin/fm-herdr-lab.sh tests/fm-afk-inject-herdr-e2e.test.sh
  • bin/fm-lint.sh
  • bin/fm-doc-audience-check.sh
  • bin/fm-test-run.sh --all and the changed selection were run. Their two concrete red results reproduce unchanged on clean origin/main: the Herdr presentation fixture-worktree reuse check and the watcher warning-text assertion.
  • The Pi/Herdr opt-in smoke was skipped because pi is unavailable on this machine.

No merge requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T11:13:03.083824Z 9f0129d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant