Make the bundled bliss timer portable plain C - #946
Merged
Merged
Conversation
timer.cc did not compile on native Windows (mingw, see gap-system/gap#4157) for lack of sys/times.h. Its times() calls were already commented out, so the timer computed durations from an uninitialized struct; use clock() with the matching CLOCKS_PER_SEC divisor instead, which is standard C, needs no unistd.h or sys/times.h, and actually measures something. With this, the whole digraphs kernel module builds and loads on native Windows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 50 50
Lines 21189 21189
Branches 639 639
=======================================
Hits 20649 20649
Misses 475 475
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timer.cc did not compile on native Windows (mingw, see
gap-system/gap#4157) for lack of sys/times.h. Its times() calls were
already commented out, so the timer computed durations from an
uninitialized struct; use clock() with the matching CLOCKS_PER_SEC
divisor instead, which is standard C, needs no unistd.h or
sys/times.h, and actually measures something.
With this, the whole digraphs kernel module builds and loads on
native Windows.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com