Graphviz

[james-d-mitchell]

This is a reworking of #639, which goes a bit further than #639 in removing the old stuff for displays. This PR doesn't introduce any breaking changes except that we now require the graphviz package. So this PR shouldn't be merged until there is a release of `graphviz'.

[james-d-mitchell]

TODO:

• doc
• tests for code coverage

[james-d-mitchell]

The CI will likely fail here until:

gap-packages/GraphvizForGAP#21

is merged.

[james-d-mitchell]

This might be a bit much for this week, but maybe not.

[wilfwilson]

This is really cool!

[wilfwilson]

In the text of the Digraphs manual, we sometimes use the US spelling color and sometimes we use the British spelling colour. I suggest we standardise at some point.

[wilfwilson]

Why is this file part of this PR? Should it be a separate one?

[james-d-mitchell]

Good point, removed!

[wilfwilson]

I've rebased this on main to resolve the merge conflict and see how the tests are running, and remove a couple of obsolete/untracked files, hope you don't mind @james-d-mitchell.

[james-d-mitchell]

Thanks @wilfwilson don't mind even a little bit

[james-d-mitchell]

@fingolfin

[codecov]

Codecov Report

❌ Patch coverage is 99.16667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.98%. Comparing base (fcfe652) to head (17baf40).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
gap/deprecated.gi	96.77%	3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (99.16%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   97.45%   97.98%   +0.53%     
==========================================
  Files          50       52       +2     
  Lines       21189    21142      -47     
  Branches      639      639              
==========================================
+ Hits        20649    20717      +68     
+ Misses        475      360     -115     
  Partials       65       65              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[james-d-mitchell]

@mtorpey this is the PR I was talking about

[mtorpey]

I'm happy with the method as it's implemented.

I see what you mean. We've got

• Functions that make a simple GraphViz object and mutate it till it's finished; and
• This function, which prepares all the data and passes it into an existing function.

But I think that's a sensible use of abstraction.