Repository navigation
Conversation
… text Each Details row's value starts with a small mark (✓, ⓘ, ✕). It was laid out inline, as part of the text, so a word too long to fit beside it, such as an issuer's did:key, left the mark alone on the line above, and a wrapped value's next line started back under the mark rather than under the first word. The mark is now a bullet: a flex item beside the words, on their first line, with every line of the words starting just after it. Stacked, the value still starts under its label. Side by side, the mark and words still sit at the row's end, but a value that wraps is start-aligned inside that, so its lines start under its first word rather than being pushed away from the mark. Right-to-left pages mirror the layout, now exactly: the old 2px margin was on the mark's right in either direction. From review: the words may shrink beside the mark (min-width: 0), so words that cannot break, in a browser without overflow-wrap: anywhere or under a host page's white-space: nowrap, no longer push the mark back over the label. The rows also set text-align themselves, so a host page that centres its text no longer centres the labels. Screen readers are given the same words as before, and the mark stays hidden from them. The did:key test expected the mark above the identifier; it now expects it beside it. The wide-row test measured a value's last line, which no longer reaches the row's end once a value wraps; it measures one-line values by their text and wrapped ones by their box. Closes #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Try it: https://digitalcredentials.github.io/verifier-plugin/pr-45/ Updates on every push to this PR, and goes away when it closes. The browser tests run against this copy too. |
Collaborator
Author
|
Closing without merging: on reflection this cosmetic change isn't worth carrying. #44 is closed as not planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
What changed
Each Details row's value starts with a small mark (✓, ⓘ, ✕). It was laid out as part of the text, which caused two problems:
did:key, left the mark alone on the line above.The mark is now a bullet. It stays on the value's first line, and every line of the value starts just after it.
CSS only (
src/verifier-credential.ts); no markup, wording or verdict logic changes.One decision to flag: in a wide card, where label and value sit side by side, a value that wraps now has its lines start-aligned (left-aligned in English) just after the mark, rather than right-aligned. One-line values still sit at the row's end as before. Across the 12 demos at 1024px, only the "Registry offline" Issuer value wraps.
Also from review:
overflow-wrap: anywhere) and host pages that setwhite-space: nowrap.Testing
mainand pass here:mainfor all 12 demos at 360px and 1024px.main:main, to within 0.5px.mainshows both bugs and this branch fixes both;tests/verifier-plugin.spec.tspasses with both packages;main. CI runs the full suite.Risk
Low. The change is cosmetic and limited to the Details rows. The worst case is a mark or line slightly out of place in some browser; the text, the verdict and what screen readers hear don't change. The wallet picks this up only when its verifier-plugin pin is bumped.
How to revert
Revert the single commit. Nothing else depends on it.
Deferred
A host page that sets
white-space: nowrapstill makes long Details values run past the card. That happens onmaintoo; it's worth a follow-up issue.🤖 Generated with Claude Code