Repository navigation
feat: make linting consistent - #624
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add the format target Makefile |
The new format target runs Black on the current directory. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Feature
Suggested reviewers: eveleighoj
Merge Risk: 
c8615
-
No actionable merge-blocking risk was identified in this formatting-only change.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the change. The PR adds a formatting target to make linting consistent across repositories. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds a
make formattarget that runsblack ., the formattermake lintchecks against.Why
Part of digital-land/config#2819, making linting the same across the data engineering repos. This repo already meets the shared standard (black 24.8.0 at 88, flake8 7.1.2 at 180 with
E203, W503ignored, pre-commit hooks,make lintin CI);make formatwas the one missing piece. It lives in this repo's Makefile rather than makerules'python.mk, because makerules is fetched at runtime by every pipeline.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
make formaton a cleanmainchanges nothing, and after adding a badly formatted linemake black-checkfails andmake formatfixes it.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit
formatcommand to format the project’s code.