skpkg: Update prokect to latest scikit-package standards - #49
Conversation
|
@stevenhua0320 This should be ready now, let me know if anything looks wrong. Thanks! |
| Authors | ||
| ======= | ||
|
|
||
| ``diffpy.srxplanar`` is developed by Xiaohao Yang and Billinge Group members. The maintainer for this project is Simon Billinge. For a detailed list of contributors see |
There was a problem hiding this comment.
We would like to keep the original authors here.
| :target: https://github.com/psf/black | ||
|
|
||
| .. |CI| image:: https://github.com/diffpy/diffpy.cmi/actions/workflows/matrix-and-codecov-on-merge-to-main.yml/badge.svg | ||
| .. |CI| image:: https://github.com/diffpy/diffpy.srxplanar/actions/workflows/matrix-and-codecov-on-merge-to-main.yml/badge.svg |
There was a problem hiding this comment.
We need to edit the directed yaml to matrix-and-codecov.yml
stevenhua0320
left a comment
stevenhua0320
left a comment
There was a problem hiding this comment.
Everything else looks good to me, please make the last edits and we could let prof. Simon to review.
|
@stevenhua0320 Got it, just made the edits. |
|
Looks good to me now @sbillinge ready to review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 48 48
=========================================
Hits 48 48
🚀 New features to boost your workflow:
|
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
looks good. Just a few small fixes needed. Please see inline comments
|
@sbillinge @stevenhua0320 Sorry for the delay, I just now saw your messages. I pushed the changes, let me know if there's anything else I should add or fix. |
@danielsirakov please set up notifications so you see these. The PR workflow often just needs a response that takes a few minutes of your time and can fit into cracks in your day, but because of its iterative nature, if you don't see it and don't respond a simple task can extend the project by weeks. On our side we try and respond quickly (within a day) and expect to get pinged if you are waiting longer than that. |
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see comments inline.
- you missed one of the author fixes
- comment about setting up notifications and responding quickly
- comment about always responding to every comment, even if it is a just one-word response. It tells us you saw it and what your thought is about it.
| "maintainer_names": "Simon Billinge", | ||
| "maintainer_emails": "sbillinge@ucsb.edu", | ||
| "maintainer_github_usernames": "sbillinge", | ||
| "contributors": "Billinge Group Members", |
There was a problem hiding this comment.
THis should be the original
There was a problem hiding this comment.
@sbillinge The original doesn't have Xiaohao Yang as an author, should I add him and his e-mail?
There was a problem hiding this comment.
yes, if possible. Good catch
There was a problem hiding this comment.
@sbillinge do you know what Xiaohao's e-mail is? I can't find it in the repository or on his github profile
There was a problem hiding this comment.
@sbillinge just following up, do you know where I could find Xiaohao's e-mail?
I have e-mail notifications on so I usually get notified right away, I'm not sure why I didn't get a push for this one. I just now also installed the GitHub app on my phone to be extra sure I get notified in the future. Sorry about the delay this caused, I won't let this happen again. |
3 participants
I ran sci-kit package update. I'm about to commit another update since I had some issues with which version of the files git was tracking so I went back in to reupdate things manually.