dep: getValue deprecation in favor of snake case - #215
Merged
Merged
Conversation
getValue was the last camelCase half of the value accessor pair; its partner setValue was renamed in c4c0b10 and shipped in 3.3.0. Follow that commit's shape: rename outright through the internal machinery (LiteralABC, Literal, Argument, Operator, ParameterProxy, ParameterAdapter) and all internal call sites, and add a forwarding @deprecated shim on the user-facing class. Unlike setValue, getValue is reachable on the Operator side of the hierarchy too, so the shim goes on Literal as well as on Parameter. Parameter's overrides Literal's, so Parameter users get a message naming Parameter.get_value and everyone else gets one naming Literal.get_value. Argument, Operator, Equation, ParameterProxy and ParameterAdapter all keep accepting getValue. This unblocks the structure and sas subpackage renames, which could not rename their getValue overrides while core still dispatched on the old name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
@sbillinge ready for review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
===========================================
+ Coverage 71.63% 82.60% +10.97%
===========================================
Files 25 27 +2
Lines 3437 4151 +714
===========================================
+ Hits 2462 3429 +967
+ Misses 975 722 -253
🚀 New features to boost your workflow:
|
Contributor
|
@cadenmyers13 thanks, nice and clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getValuedeprecation was also missed in the last release for the name deprecation. This PR deprecates it in favor of snake case.