Repository navigation
Restore ordinary networking after Disconnect and Quit - #15
Merged
devlifeX merged 5 commits intoNov 8, 2026
Merged
Conversation
asgarihope
marked this pull request as ready for review
November 8, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnect, Pause, and Quit must release BiFlow's owned capture before handing the original network back. Incomplete restoration now stays retryable, and Quit or a repeated Stop after a completed handoff no longer kills the returned proxy client.
Version: 6.2.91. ADRs 0133–0137 document ownership, recovery, and diagnostic policy.
Validation: Windows workspace rustfmt, Clippy with
-D warnings, workspace tests, cargo deny, pnpm check/build, and the full mock UI e2e suite passed (41 passed; the opt-in README capture was skipped). Development-profile tests and Apple Silicon helper/core cross-Clippy also passed. The Windows 6.2.89 release and NSIS/WXbuilds passed; that installation's desktop and both helper copies match the built artifacts, with settings preserved and the stack stopped. The macOS collector uses the shared bounded desktop command runner; the Unix stop fixture waits for explicit child readiness.Regression coverage includes explicit signal-handler readiness and SIGKILL verification for the graceful-stop fixture, executable native-command fixtures, partial DNS rollback/retry, per-launch tunnel identity, lifecycle serialization, delayed framed IPC replies, Stop followed by Quit/repeated Stop, and diagnostic classification/redaction. Automated tests do not disconnect the host network. Real network transitions on macOS still require native acceptance testing.
CI for
749a354: all seven jobs passed — Windows 2025, macOS 15, Ubuntu 22.04/24.04, frontend, e2e, and security. Verified CI run.