Skip to content

Fix network recovery, proxy handoff on Disconnect, and macOS updates - #14

Merged
devlifeX merged 7 commits into
devlifeX:mainfrom
asgarihope:codex/network-recovery-latest-main
Nov 7, 2026
Merged

devlifeX merged 7 commits into
devlifeX:mainfrom
asgarihope:codex/network-recovery-latest-main

Conversation

@asgarihope

@asgarihope asgarihope commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Windows networking could stay stale after lock/unlock or sleep, Quit could exit before privileged cleanup finished, and Disconnect discarded an existing Hiddify system proxy. macOS updates only opened a DMG and left the old menu-bar process running.

This PR:

  • Recovers owned networking after wake/unlock or persistent runtime failure, preserving Pause/Disconnect intent and serializing recovery with user actions.
  • Drains Connect and client maintenance before Quit, completes verified tunnel/DNS/route cleanup, and retains cleanup failures for retry.
  • Captures the user's managed proxy before starting clients and hands it back after tunnel cleanup only when the client is reachable and settings remain unchanged. Preserves borrowed clients, corporate/PAC choices, and an originally disabled proxy.
  • Installs and validates the signed macOS package's bundle at its actual location, rolls back failed swaps, preserves backups after rollback failure, and relaunches as the desktop user after the old PID exits.
  • Bounds macOS disk-image attach/detach commands, preserves staging when detach is unconfirmed, and records safe failure diagnostics.
  • Fixes the failing upstream DMG test setup with an explicit HFS+ filesystem and unique volume name. The test uses the production attach helper, attempts detach before failure assertions, and reports command status/stderr.
  • Fixes the Windows NSIS common-data variable contract, replaces two yanked dependencies, refreshes README screenshots, records ADRs 0130–0132, and reduces unrelated ADR-index formatting changes.

Version: 6.2.84, based on upstream main f35ece9.

Validation:

  • All upstream CI checks passed on cb32052: native Rust formatting, strict workspace Clippy/tests on Windows 2025, macOS 15, Ubuntu 22.04 and 24.04; frontend, Playwright e2e and security checks.
  • macOS desktop tests: 166 passed, zero failures or ignored tests, including the previously failing real-DMG mount/install/detach case and stalled-command coverage.
  • Full local commit gates and frontend build passed. Desktop tests also passed with BIFLOW_DEV_PROFILE set.
  • Proxy regressions cover live/dead clients, auto-started versus borrowed clients, intervening settings changes, unused Quit, and restoration only after capture is detached.
  • Windows 6.2.84 release build and NSIS compilation with /WX passed. Installed successfully (exit 0); installed desktop, packaged helper, and active SYSTEM helper match the build. Runtime reports helper 6.2.84 available and authorized. The existing Hiddify system proxy remained enabled after tunnel cleanup, and an HTTPS request succeeded with BiFlow stopped. The updated app starts successfully.

Physical Windows lock/unlock, a final live proxy handoff on Disconnect, and an administrator-authorized signed-release upgrade on a physical Mac remain acceptance tests. Certificate validation remains enabled.

@asgarihope asgarihope changed the title Fix network recovery after unlock, Quit cleanup, and macOS updates Fix network recovery, proxy handoff on Disconnect, and macOS updates Nov 7, 2026
@devlifeX
devlifeX merged commit 33cc673 into devlifeX:main Nov 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants