Conversation
EdCaunt
requested review from
FabioLuporini,
JDBetteridge and
mloubout
and removed request for
mloubout
October 5, 2026 10:34
| memptr = VOID(Byref(obj._C_symbol), '**') | ||
| alignment = obj._data_alignment | ||
| nbytes = SizeOf(obj._C_typedata)*as_long(obj.size) | ||
| size = prod(as_long(i) for i in obj.symbolic_shape) |
Contributor
There was a problem hiding this comment.
looks like this could use a utility function (somewhere in symbolics.py?) , reusable across OSS and PRO?
Contributor
There was a problem hiding this comment.
I don't understand that change, as_long should already rebuild every arg of a Mul as long
Contributor
Author
There was a problem hiding this comment.
Didn't spot that - nice
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
+ Coverage 84.13% 84.14% +0.01%
==========================================
Files 258 258
Lines 56513 56526 +13
Branches 4825 4825
==========================================
+ Hits 47547 47564 +17
+ Misses 8140 8137 -3
+ Partials 826 825 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EdCaunt
force-pushed
the
temp_alloc_cast
branch
2 times, most recently
from
October 5, 2026 11:28
d581fee to
2c82d71
Compare
…temp array allocation sizes
EdCaunt
force-pushed
the
temp_alloc_cast
branch
from
October 5, 2026 11:40
2c82d71 to
5a22a69
Compare
mloubout
approved these changes
Oct 5, 2026
EdCaunt
force-pushed
the
temp_alloc_cast
branch
from
October 5, 2026 14:33
ebb1e31 to
e100bb6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.