compiler: Remove IET visitor result memoization - #3039
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
+ Coverage 83.99% 84.13% +0.14%
==========================================
Files 258 258
Lines 56422 56449 +27
Branches 4815 4817 +2
==========================================
+ Hits 47389 47491 +102
+ Misses 8203 8135 -68
+ Partials 830 823 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cached results and cache partitions can keep temporary IET roots alive despite weak cache keys. Remove shared result memoization from FindNodes, FindSymbols and FindApplications, along with the unused helper and the redundant FindWithin.visit override. Add regression coverage for root and child retention, scope query targets, returned back-references, repeated visits, subclasses and copied Operators. For a space-order-16 3D TTI Born Operator, six paired runs changed median construction and code generation from 21.18s to 21.24s with identical C.
FabioLuporini
force-pushed
the
fix-memleak
branch
from
October 1, 2026 14:02
efa49ba to
eae0039
Compare
mloubout
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached results and cache partitions can keep temporary IET roots alive despite weak cache keys. Remove shared result memoization from FindNodes, FindSymbols and FindApplications, along with the unused helper and the redundant FindWithin.visit override.
Add regression coverage for root and child retention, scope query targets, returned back-references, repeated visits, subclasses and copied Operators.
For a space-order-16 3D TTI Born Operator, six paired runs changed median construction and code generation from 21.18s to 21.24s with identical C.