Conversation
Column-level access rules (backendOnly, editReadonly, showIn,
allowModifyWhenNotShowIn*) lived as private helpers inside restApi.ts, so every
plugin re-implemented them by hand and each copy dropped a different check.
Add adminforth.resource(id).asUser(adminUser, { meta }) and .asSystem({ hooks })
as the single entry point for resource access, backed by one pipeline:
- columnAccess.ts owns backendOnly/showIn resolution, record write policy, read
stripping, and aggregation column exposure
- resourceAccess.ts owns interpretResource, breaking the restApi/connector
import cycle
- create_record, update_record, delete_record and aggregate go through the
scoped API, so the core path and the plugin path cannot drift apart
- createResourceRecord/updateResourceRecord/deleteResourceRecord and unscoped
resource() calls remain as deprecated aliases with runtime warnings
- a denied or failed operation is always visible: reads and delete throw, create
and update resolve to { ok, error }
Also fixes /aggregate, which resolved allowedActions with a single ListRequest
pass and then required allowedActions.show, which that source always sets to
false, so the endpoint rejected every request. list and show are now resolved
separately.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.