Fix Dockerfile ARG continuation parsing - #1299
Open
SimonYang (simonyang08) wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
SimonYang (simonyang08)
marked this pull request as ready for review
August 30, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1286
Summary
ARGinstructionENVandUSERbuildArgs-overridden valuesRoot cause
The lightweight Dockerfile scanner matched physical lines and recorded only one name/value pair for each
ARGinstruction. Docker joins continuation lines before parsing, so the second declaration was invisible to the CLI even though Docker/BuildKit accepted it. A laterFROMreference therefore resolved to an empty value and produced an invalid image reference.Validation
dockerfileUtilssuite: 70 passingnpm run type-check: passednpm run lint: passedgit diff --check: passedThe repository-wide
npm testscript uses Unixenv/rmcommands and is not directly runnable from the current Windows shell. The focused parser suite covers the changed module; upstream CI should provide the remaining platform and integration validation.AI disclosure
This change was prepared with OpenAI Codex assistance and reviewed and validated locally by the contributor.