Repository navigation
Let getFixVersion count only advisories at least a severity - #123
Merged
irskep merged 1 commit intoOct 14, 2026
Merged
Conversation
irskep
force-pushed
the
fix-version-by-severity
branch
from
October 14, 2026 23:23
cd740f0 to
4477546
Compare
A policy that files tickets for high and critical advisories wants the
release that fixes those, due four weeks after it shipped. The fix
version on a finding is the lowest release that fixes every advisory,
so a medium advisory fixed later moved the ask and the deadline to its
release. getFixVersion(store, name, version, { minSeverity: 'high' })
leaves the medium out.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
irskep
force-pushed
the
fix-version-by-severity
branch
from
October 14, 2026 23:23
4477546 to
44d2bab
Compare
Collaborator
Author
|
Folded into #121. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFixVersionreturns the lowest release that fixes every advisory on a version. A spec that only files issues for high and critical advisories wants the release that fixes those. If a medium advisory's fix shipped later, the issue asked for that later release and counted its due date from it, so the high finding came due late.getFixVersion(store, name, version, { minSeverity: 'high' })counts only the advisories at least that severe. An advisory with no severity of its own takes the severity of its finding. A finding without per-advisory detail is counted or left out as a whole. Without the option, nothing changes.🤖 Generated with Claude Code