Skip to content
dentech-flossPublic

About

Combined HTTP and gRPC server for CloudRun instances, instrumented by OpenTelemetry

Topics

Resources

Stars

1 star

Watchers

0 watching

Forks

Latest commit

 

History

96 Commits

Folders and files

NameName
Last commit message
Last commit date
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

server

Since we only have one port on Cloud Run, but want to serve both the "native" gRPC server and the gRPC-Gateway we have applied the ideas from here: Serving gRPC+HTTP/2 from the same Cloud Run container to get this to work.

Opentelemetry instrumentation is configured for the gRPC server via the otelgrpc lib to intercept both unary and stream communication.

Which handler to use is configurable, provide your implementation of choice by setting "HttpAndGrpcHandlerFunc" in the config. If this is not provided then the "DefaultHttpAndGrpcHandlerFunc" is used, and we also provide a "CorsHttpAndGrpcHandlerFunc" that handles preflight requests so have a closer look at: handlers.go.

Install

go get github.com/dentech-floss/server@v0.3.0

Usage

package example

import (
    "github.com/dentech-floss/server/pkg/server"
)

func main() {

    ctx := context.Background()

    ...

    appointmentServiceV1 := service.NewAppointmentServiceV1(repo, publisher, logger)
    patientGatewayServiceV1 := service.NewPatientGatewayServiceV1(repo, publisher, logger)

    ...

    server := server.NewServer(
        &server.ServerConfig{
            Port: config.Port,
            // The "server.DefaultHttpAndGrpcHandlerFunc" will be used if you don't set this
            // HttpAndGrpcHandlerFunc: server.CorsHttpAndGrpcHandlerFunc // ...for cors...
            // You can also add the WithRealIP option to enable getting the user's IP address via realip.FromContext.
            // WithRequestLogFields: true, // see "Request log fields" below
        },
    )

    appointmentServiceV1.Register(server.GrpcServer)
    appointmentServiceV1.RegisterMux(ctx, server.GrpcMux) // if you use the grpc gateway

    patientGatewayServiceV1.Register(server.GrpcServer)
    patientGatewayServiceV1.RegisterMux(ctx, server.GrpcMux)

    go server.Serve()
    handleShutdown(server, logger)
}

func handleShutdown(
    server *server.Server,
    logger *logging.Logger,
) {
    done := make(chan os.Signal, 1)
    signal.Notify(done, os.Interrupt, syscall.SIGINT, syscall.SIGTERM)
    sig := <-done // Block until we receive our signal
    logger.Info("Got signal: " + sig.String())

    ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
    defer cancel()
    if err := server.Shutdown(ctx); err != nil {
        logger.Warn("Server shutdown failed: " + err.Error())
    }
}

Request log fields

Set WithRequestLogFields: true to add two log fields to the context of every unary gRPC call:

  • grpc.method: the full method name, e.g. /api.patient.v1.PatientGatewayService/FindTreatments.
  • request: the request as JSON, when it's a protobuf message.

Every entry logged with that context through a *Context method of a dentech-floss/logging logger includes them, also in helpers further down the call chain:

func (s *PatientGatewayServiceV1) FindTreatments(
    ctx context.Context,
    request *patientv1.FindTreatmentsRequest,
) (*patientv1.FindTreatmentsResponse, error) {
    ...
    // Includes grpc.method and request
    s.logger.ErrorContext(ctx, "Find treatments failed", logging.Error(err))
}

The request is logged with logging.Proto, which leaves out every field marked with [debug_redact = true] in the .proto schema and only serialises the request if something is actually logged. Before you turn this on, mark the sensitive fields in the schemas your service serves (personal data, health information, free text, secrets). See Redacting sensitive fields in the logging README.

The interceptor is in the requestlog package if you build the gRPC server yourself:

grpc.NewServer(grpc.ChainUnaryInterceptor(requestlog.UnaryServerInterceptor()))

About

Combined HTTP and gRPC server for CloudRun instances, instrumented by OpenTelemetry

Topics

Resources

Stars

1 star

Watchers

0 watching

Forks

Releases

Used by

Contributors

Languages