Repository navigation
test: tolerate Codex daemon reconciliation race - #917
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #916 and #915.
Post-merge CI exposed a repeatable race in
tests/sessions.nix: direct wrapper tests intentionally stop the same user-wide Codex daemon supervised by thehelperpane. The pane can disappear after the test reads its PID but before the deliberatekill-session, causing the test to fail even though the supervisor is reconciling it correctly.Retry the deliberate kill until reconciliation supplies a live pane. The existing assertion still requires the subsequent pane PID to differ from the original, so the restart behavior remains covered.
Validation:
nix build -L --keep-going .#ci-nativegit diff --checkThe sessions VM lane will exercise the reproduced race on GitHub CI.