fix(plotly-express): Decorrelate Exchange from Sym in stocks data - #1409
Open
mofojed wants to merge 3 commits into
Open
fix(plotly-express): Decorrelate Exchange from Sym in stocks data#1409mofojed wants to merge 3 commits into
mofojed wants to merge 3 commits into
Conversation
Sym and Exchange were both seeded with Index, so each drew the same underlying uniform value and Exchange became a pure function of Sym. Only 7 of the 15 Sym/Exchange combinations could ever occur (CAT was never on TPET, DOG was always PETX). Offset the exchange seed so it draws from an independent, still deterministic stream.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The deterministic seed fix and corresponding test and snapshot updates have no unresolved issues.
Pull request overview
Decorrelates deterministic stock symbol and exchange generation while preserving reproducible output.
Changes:
- Offsets the exchange RNG seed.
- Updates affected UI tests and documentation snapshots.
File summaries
| File | Description |
|---|---|
tests/ui_table.spec.ts |
Updates selection expectations. |
plugins/ui/docs/snapshots/d17037c4accf100f79072ead620466e1.json |
Refreshes query-parameter output. |
plugins/ui/docs/snapshots/a0ba791beed7cb302f80b3b85244b528.json |
Refreshes interactive plot output. |
plugins/ui/docs/snapshots/74f478444ea2729b5ebfdf089eaad4ea.json |
Refreshes table serialization. |
plugins/ui/docs/snapshots/228ad0434a83ac64357bc939a56e553a.json |
Refreshes query-parameter output. |
plugins/ui/docs/snapshots/146d658ec29ddc0e62334de0ea0fbb9c.json |
Refreshes UI table output. |
plugins/plotly-express/src/deephaven/plot/express/data/data_generators.py |
Uses a distinct deterministic exchange seed. |
plugins/plotly-express/docs/snapshots/85be7fc6e1425eefd9038059092c01a6.json |
Refreshes event-example data. |
plugins/plotly-express/docs/snapshots/49d3fd3db5d3ff802a3dbdf52c76eb1e.json |
Refreshes example stock data. |
Review details
- Files reviewed: 18/66 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
plotly-express docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
dsmmcken
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sym and Exchange were both seeded with Index, so each drew the same underlying uniform value and Exchange became a pure function of Sym. Only 7 of the 15 Sym/Exchange combinations could ever occur (CAT was never on TPET, DOG was always PETX). Offset the exchange seed so it draws from an independent, still deterministic stream.