feat(agent): add raw control sender - #789
Open
GregHolmes wants to merge 1 commit into
Open
GregHolmes wants to merge 1 commit into
GregHolmes wants to merge 1 commit into
Conversation
GregHolmes
requested review from
deepgram-kiley and
dg-coreylweathers
as code owners
September 14, 2026 12:20
Contributor
|
dg-coreylweathers
left a comment
dg-coreylweathers
left a comment
Contributor
There was a problem hiding this comment.
Verdict: approve with nits.
What this PR does
Adds public send_raw(message: Dict | str) on the sync and async Voice Agent socket clients so protocol-transparent bridges can forward any control frame without calling the private _send() (issue #785). Dicts are JSON-serialized; strings are sent byte-for-byte.
What I checked
- Does it send unchanged? Yes:
_senddoesjson.dumpsfor dicts and passes strings straight towebsocket.send; the four new tests capture exactly that, including that44100.0is not converted to an int. - Is the patch protected from regen? Yes:
agent/v1/socket_client.pywas already frozen; the PR adds the ledger bullet. - Gates in Docker: mypy clean, ruff clean on changed files, pytest 1038 passed.
Should-fix
send_rawappears only in the socket client, its tests,.fernignore, andAGENTS.md. Add asend_raw(message)line to the agent.v1 section ofreference.mdand a one-line mention in a voice-agent example or the skill file, otherwise bridge authors keep using_send().- State the number contract in the docstring: "Values are sent as given; whole-number floats are not converted to integers, so pass ints where the API expects them." That is what the tests pin and how it differs from the typed senders.
Nits: the Union[Dict, str] annotation is narrower than _send accepts (bytes also work), fine as the public contract. Needs a rebase: AGENTS.md/.fernignore conflict with main now, and after #797 lands agent/v1/socket_client.py is regenerated, so re-apply the two methods there.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_raw()methods for protocol-transparent Agent control-frame bridges.Closes #785
Validation