Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashable ABC membership does not guarantee that hash(tag) succeeds: tuples containing lists and custom hash implementations can still raise TypeError. Job.tag currently passes those inputs to set.update, adding earlier tags before failure.
Hash every proposed tag before changing the job tag set and report the existing Tags must be hashable error consistently. Two regressions check nested unhashable tuples and a failing hash method, verifying existing tags remain intact.
Validation: both cases fail before the patch. Full Python 3.12 tox suites pass with pytz (83 tests) and without pytz (42 passed, 41 skipped); Mypy passes both. The required Black 20.8b1 full-tree check passes on Python 3.10 after its default Python 3.14t environment could not build typed-ast.