Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job.at()currently accepts a terminal newline (for example,every().day.at("12:30\n")). The regex end anchor permits the final newline, and integer conversion then strips it, so malformed daily, weekly, hourly and minutely inputs become valid job times.Use
re.fullmatch()for the three supported time formats. The regression checks all six supported forms with a trailing newline; existing valid-format tests remain unchanged.Validation on Python 3.12: the new regression fails before the change; the full suite passes afterward (82 tests), mypy passes, and the repository-pinned Black 20.8b1 accepts both changed files.
git diff --checkpasses.Prepared with AI assistance. Upstream CI status will be reported by GitHub.