Repository navigation
Test midnight timezone jobs do not run on every poll - #664
Open
salapenar-max wants to merge 1 commit into
Open
salapenar-max wants to merge 1 commit into
salapenar-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily jobs just after midnight in Europe/Berlin or Europe/Amsterdam could run immediately at startup and then on every poll when the host timezone was UTC (#609). The existing timezone fixes released in 1.2.2 correct the tested scenario; this PR adds explicit regression coverage for the runaway execution behavior.
The test covers 12 combinations: midnight, 00:05, and 00:30; Berlin and Amsterdam; winter and summer offsets. It checks the exact next-run timestamp, no execution at startup, one execution across five consecutive polls, and another execution at the next day's scheduled time.
Validation on Linux/Python 3.13 with pytz 2026.5:
python -m pytest test_schedule.py -q— 82 passed, 12 subtests passed.git diff --checkpasses.Related to #609. This does not establish that every report in that thread is resolved, including the report mentioning 1.2.2; the coverage is limited to the configurations above and does not exercise a DST transition.
AI disclosure: OpenAI Codex investigated the report, wrote the regression test, and executed the checks on behalf of the submitting account owner.