Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing jobs with the same callback and hourly interval currently produces identical descriptions even when each job has a different
.at()setting, as reported in #635.Include the configured time in
Job.__str__when present, using the same canonical time representation asJob.__repr__. For example, an hourly job with.at(":10")now prints:Jobs without
.at()keep their existing string output. The regression tests cover the six hourly offsets in the report, as well as daily, hourly and minute schedules with callback arguments.Validation:
python -m pytest test_schedule.py schedule -v --cov schedule --cov-report term-missing— 83 tests and 3 subtests passed; 99% coverage.python -m mypy -p schedule— passed.black --check .— passed.git diff --check— passed.Refs #635.
AI disclosure: this change and its regression tests were prepared and checked with Codex assistance. The test results above are from actual local runs.