Repository navigation
Preserve job configuration when at or until rejects input - #659
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejected job configuration currently can overwrite previously valid settings:
.at("25:00", "Europe/Amsterdam")changes an existing UTC timezone before raising, and.until()with a past deadline replaces the existing deadline before raising.Validate the candidate time and deadline before assigning them to the job. Three regression tests cover preserving an existing time/timezone, preserving an existing deadline, and leaving an initially unset deadline unset after rejection.
Validation: all three regressions failed before the fix; the full local suite passes (84 tests), and mypy passes for
schedule. No claim of upstream CI completion yet.AI-assisted contribution; changes and regression evidence reviewed before submission.