Repository navigation
Remaining project settings, and a per-scene opt-out from project overlays - #19
Merged
Merged
Conversation
…ect overlays Settings tab: backgrounds and fitting (background, fit, shortest scene), title and chapter cards, quote and code panels, the watermark, text on every scene, and a default transition beside the default camera. Each writes only what differs from the spec's defaults and removes a group left empty (`patchSetting`); the watermark and overlay text are written in full, since a block's presence means on. A scene can now hide the project-wide watermark, text and wave (`segment.chrome`), shown only when the project draws any. Number boxes keep what is being typed and pass on only an in-range value. The Output and Voice boxes from the last change refused to start a value such as 0.9 where 0 alone is out of range, so they use the new field too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHkHXgxVVH3dn6EAVL9rbN
davior
marked this pull request as ready for review
October 24, 2026 05:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the Settings tab, and adds the per-scene opt-out.
New sections
Per-scene opt-out. A scene can hide the project-wide watermark, text and wave (
segment.chrome). It only appears when the project draws something, and names the default (off for an intro or outro). The renderer already honoured the field.Settings are written the same way as before: only what differs from the spec's defaults, with an emptied group removed (
patchSetting). The watermark and text blocks are written in full, since a block's presence means on.A fix to my last PR
The Output and Voice number boxes refused to start a value like
0.9where0alone is out of range, so a speed could not be typed. Number boxes now keep what is typed and pass on only an in-range value (NumberField); those two sections use it, and a test types0.9the way a person would.Checked
A spec carrying every field these sections write validates against the backend model, and the renderer reads each of them. Frontend: 182 passed, lint clean,
npm run buildtypechecks. Backend: 700 passed, unchanged.Not built
voice.providerandvoice.expressivity: the renderer does not read them.Generated by Claude Code