Repository navigation
Settings tab: audio wave, Output and Voice - #18
Merged
Merged
Conversation
The spec has always had `chrome.waveform` (what Notes draws across a whole video) and the renderer honours it, but nothing in the editor could set it. A new Settings tab holds it, with the same settings and defaults as a scene's wave layer; the shared vocabulary moves to spec/waveform.ts. The project's default camera moves there from the Scenes tab, so the tab is the one home for what applies to the whole video. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHkHXgxVVH3dn6EAVL9rbN
Output: shape, size, quality, frame rate, subtitles, chapter marks and cover picture. Voice: a named voice, speaking speed and the three pauses. Both write only what differs from the spec's own defaults, and remove a section left empty. The spec also has `voice.provider` and `voice.expressivity`, which the renderer does not read yet (it warns about expressivity), so there are no controls for them: a control that does nothing is worse than none. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHkHXgxVVH3dn6EAVL9rbN
davior
changed the title
davior
marked this pull request as ready for review
October 24, 2026 05:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new Settings tab for what applies to the whole video.
chrome.waveform). The spec and renderer already supported it; nothing in the editor could set it. Same settings and defaults as a scene's wave layer.Each setting writes only what differs from the spec's own defaults (checked against the backend model) and removes a section left empty, so a spec keeps to what was actually said.
spec/settings.tsholds these as pure spec-to-spec functions, so a future project template can be a partial spec applied over the same fields.Deliberately not built
voice.providerandvoice.expressivityexist in the spec, but the renderer does not read them (it warns about expressivity). A control that does nothing is worse than none, so they have none until the renderer honours them.Tests
Frontend: 168 passed, lint clean,
npm run buildtypechecks. Backend untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_01XHkHXgxVVH3dn6EAVL9rbN