Repository navigation
Import a note's pictures and videos through the assistant; film-reel favicon - #16
Merged
Merged
Conversation
… via the assistant, and give GVC a film-reel favicon Attaching a note now records the files Notes serves for it, listed to the assistant as n1, n2… with the heading each sat under. A new import_note_media tool copies chosen ones into the user's GAM library and registers them as assets. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013EMeBgQuEmbgiJXN3Jkioz
davior
marked this pull request as ready for review
October 24, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Notes' own media via the assistant. Attaching a Gecko Notes note to the assistant now also records the pictures, videos and sounds the note holds (only files Notes serves from
/media/, in reading order, each with the heading it sat under). The assistant sees them asn1,n2… in the attachment, and a newimport_note_mediatool copies the chosen ones into the user's GAM library and registers them as assets in the working spec. It can then place them withset_visual,add_overlayoradd_audio_track.So: attach a note, then ask "import this note as a script, using the images and videos from it", and the proposal contains the script plus the note's media on the matching scenes.
_safe_pathcheck still applies.note_media.copy_file).generate_image. A discarded proposal leaves them in the library.Favicon. A film reel on a violet tile, to tell GVC apart from GAM (blue) and Notes (green). SVG, 32px PNG and apple-touch icon regenerated.
Testing
pytest -q: all pass (new tests for media extraction, the attachment listing, and the tool's copy / register / dedupe / unknown-id behaviour)npm testandnpm run build: passNot done: merging a note into an existing project's scenes beyond what the assistant already does with an attached note; no UI change (the attachment chip doesn't show a media count yet).
Generated by Claude Code