Repository navigation
Offer Camera on generated pictures, and set the project's default move - #15
Merged
Merged
Conversation
The scene card worked out whether its picture was a still with its own lookup, which knew GAM and search refs but not generated ones, so a generated picture never got a Camera control. It now uses footageOf, as the thumbnail already did. A scene's "Project default" camera meant style.motion, which defaults to no move and which nothing in the editor could set. The Scenes tab now has a "For every scene" Camera (any preset, or alternate) with its amount, and each scene's default option names the move it follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014PPyHwCtvqQbpW2Hvrb63Z
davior
marked this pull request as ready for review
October 23, 2026 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some scenes that show a picture had no Ken Burns move. There were two causes:
SceneSettingsused its ownpictureOflookup to decide whether a scene's picture is a still. That lookup recognisedgamandsearchrefs but notgenerate, so a generated image never got the Camera dropdown. The thumbnail strip already usesfootageOf, which does handlegenerate.style.motion, which defaults toeffect: "none", and nothing in the editor could set it.What
SceneSettingsnow resolves its picture withfootageOf(spec/clip.ts), so generated, searched and library pictures are all treated the same.ProjectDefaultscard at the top of the Scenes tab, labelled "For every scene". It has a Camera dropdown with every preset plus "Alternate zooms and pans" (no path, which the spec refuses project-wide) and an optional amount (0.02–0.5, placeholder 0.12).style.motioninstead of writing the default into the spec.spec/scene.ts:PROJECT_MOTIONS,motionLabel,setProjectMotion.No backend change: the renderer already applies
style.motionto every still, generated or not.Tests
SceneSettings.test.tsx: a generated picture gets the Camera control, and its option names the project default.ProjectDefaults.test.tsx: sets, adjusts and clearsstyle.motion, and does not offer a path.npm test(158 passed),npm run build,npm run lintand Prettier are clean.Generated by Claude Code