Repository navigation
ci: Run Windows lanes on windows-latest and drop JFrog - #1095
Open
max-rozen-oss-db wants to merge 3 commits into
Open
max-rozen-oss-db wants to merge 3 commits into
max-rozen-oss-db wants to merge 3 commits into
Conversation
GitHub-hosted windows-latest reaches public PyPI and npm, so the Windows lanes no longer need the JFrog OIDC login. Fork PRs can't mint OIDC tokens, which made every Windows job fail on them. Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
marked this pull request as ready for review
October 10, 2026 02:16
max-rozen-oss-db
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
October 10, 2026 02:16
Only the Windows JFrog lanes set these env vars, so with JFrog gone the installer credential passthrough and npmrc writing are dead code. Co-authored-by: Isaac <no-reply@databricks.com>
rohita5l
approved these changes
Oct 12, 2026
max-rozen-oss-db
enabled auto-merge
October 12, 2026 22:10
max-rozen-oss-db
disabled auto-merge
October 12, 2026 22:11
Drops databricks#1080's fork guard and contract test: without JFrog the Windows lanes need no OIDC token, so fork PRs can run them. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs fail every Windows job in
ci.ymlbecausewindows-server-latestcan't reach public PyPI or npm, so it installs through JFrog with a GitHub OIDC token, and fork PRs never get one (Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable, see #1049). This moves the Windows lanes to GitHub-hostedwindows-latest, which reaches public registries, and removes JFrog.ci.yml,integration.yml:windows-server-latest→windows-latest. Drop the JFrog login steps,id-token: write, the OIDC credential env, the JFrog index/registry URLs, and the Windows-only install branches.installation-windowsis credential-free now, so it drops its fork guard and runs on fork PRs. Live Windows jobs still skip forks because they need workspace secrets.scripts/run_integration.py: remove the installer credential passthrough,npm_user_config, and.npmrcwriting that Add advisory Windows installation CI with authenticated package proxies #786 added for JFrog. Nothing sets those env vars anymore.--default-index,--npm-registry, and output redaction stay.Reverts #1080: its
osmatrix fork guard andtest_ci_windows_lanes_skip_fork_pull_requestsonly existed because the Windows lanes needed a JFrog OIDC token. This PR is opened from a fork to show the Windows lanes pass under fork conditions.Known gap: JFrog served a Gemini CLI build under ucode's version ceiling; public npm serves the latest, so
TestGeminiLaunchwill skip on Windows like it already does on Linux.Tests:
uv run pytest tests/test_integration_contract.py tests/test_integration_runner.py(80 passed after merging main),just lintclean. This fork PR's CI is green onwindows-latestwith no OIDC errors: Windows unit tests ran in full (3908 passed), Windows installation tests passed, and the agent CLIs installed from public npm. The credentialed e2e and live Windows journeys skip on forks, so they still need a same-repo run.This pull request and its description were written by the Isaac LLM tool (Claude Code, session
f636bd94-7485-4f34-ae16-732fc5ee0867).