Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation and validation logic align with the documented behavior, and the PR adds focused test coverage for both the MCP union path and CLI parsing/dispatch.
Pull request overview
This PR adds a new ucode skill add CLI command to support additive Skills configuration: it can either (1) union new UC skill schema scopes into the existing Skills MCP connection (--mcp), or (2) download skills to disk without removing existing downloads, including support for selecting named skills via bare or fully-qualified identifiers.
Changes:
- Added
ucode skill addCLI surface area with validation for--location,--mcp,--path, and--skills(including fully-qualified<catalog>.<schema>.<name>handling). - Implemented additive Skills MCP scope updates via
_union_locations(...)andadd_skills_command(...). - Added test coverage for both the unioning behavior and CLI argument parsing/dispatch, plus README documentation for the new command.
File summaries
| File | Description |
|---|---|
tests/test_mcp.py |
Adds unit tests for _union_locations and add_skills_command additive scope behavior. |
tests/test_cli.py |
Adds CLI tests ensuring ucode skill add validates flags correctly and dispatches to MCP union vs download modes. |
src/ucode/mcp.py |
Introduces _union_locations and add_skills_command to merge new schema scopes into the existing Skills MCP connection. |
src/ucode/cli.py |
Adds the skill Typer sub-app and skill add command, including --skills parsing for named/fully-qualified selection. |
README.md |
Documents ucode skill add usage and adds it to the command summary table. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
_union_locations does not normalize duplicates already present in the existing base scope, which can preserve repeated locations and propagate them into persisted state/URL generation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
Add the ucode skill add command for additive MCP schema registration and skill downloads, including named and fully-qualified skill selection.
Summary
ucode skill addcommand namespace.ucode configure skillsbehavior.Part 1 of the skill CLI series.
Testing
uv run ruff check .uv run ty check src/uv run pytest tests/test_skills_download.py tests/test_mcp.py tests/test_cli.py -qStack created with GitHub Stacks CLI • Give Feedback 💬