Bump dbt-sql to DBR 16.4 LTS for classic compute - #6418
Open
rugpanov wants to merge 1 commit into
Open
Conversation
Collaborator
Integration test reportCommit: 16953f4
Top 3 slowest tests (at least 2 minutes):
|
rugpanov
force-pushed
the
dbt-sql-versions-tmpl-followup
branch
from
August 28, 2026 09:00
c0f06e2 to
16953f4
Compare
rugpanov
changed the title
rugpanov
marked this pull request as ready for review
August 28, 2026 09:23
Contributor
Approval status: pending
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
## Changes Delete `libs/template/templates/default-sql/library/versions.tmpl`. The `default-sql` bundle template renders no cluster (it targets a SQL warehouse), so its two macros — `latest_lts_dbr_version` and `latest_lts_db_connect_version_spec` — are never referenced by any template. The file contained only these two dead macros. Split out of #6418 (dbt-sql DBR 16.4 bump) to keep that PR focused on a single change. ## Tests - No rendered template output changes (the macros were never invoked); no changelog fragment needed. - `default-sql` template acceptance tests pass unchanged after the deletion. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
Follow-up from #6378: - dbt-sql: bump latest_lts_dbr_version 15.4 -> 16.4 LTS for classic (non-serverless) compute, matching the default template's 16.4 pin and aligning the cluster runtime's Python version (3.12) with serverless environment version 5. - Remove the unused, TODO-flagged latest_lts_db_connect_version_spec macro from dbt-sql (flagged for removal in #6378; no references). - Add a dbt-sql-classic acceptance variant exercising the classic new_cluster path, locking in the bumped spark_version. Co-authored-by: Isaac <no-reply@databricks.com>
rugpanov
force-pushed
the
dbt-sql-versions-tmpl-followup
branch
from
August 31, 2026 11:26
16953f4 to
14882d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up from #6378: bump the
dbt-sqlbundle template's classic (non-serverless) compute to Databricks Runtime 16.4 LTS.latest_lts_dbr_versionfrom15.4.x-scala2.12to16.4.x-scala2.12. This matches thedefaulttemplate (already pinned to 16.4) and aligns the cluster runtime's Python version (3.12) with serverless environment version 5.latest_lts_db_connect_version_specmacro (flagged for removal in Bump default serverless environment version to 5 #6378; no template references it).The unrelated dead-code removal in
default-sql/library/versions.tmplwas split into #6420 (merged); this branch is rebased on top of it.Tests
acceptance/bundle/templates/dbt-sql-classicinitializes dbt-sql withserverless: noand diffs the generated job against the serverless golden, locking in the classicnew_clusterspark_version: 16.4.x-scala2.12. Before this, no acceptance test rendered the classic (non-serverless) path.dbt-sqltest's committed golden, so any change to the basedbt-sqljob template requires regenerating both goldens.This pull request and its description were written by Isaac.