Repository navigation
Validate unsigned compilation IDs and flags - #272
Closed
sricharanreddycheruku wants to merge 1 commit into
Closed
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation silently truncates Python integers into 32-bit fields: flags=232 becomes 0, and ID 232+7 is returned as 7. Scalar conversion errors are also cleared while handling sequence flags, hiding TypeError/OverflowError behind native compiler errors.
Validate IDs and flags before narrowing; distinguish sequence flags before scalar conversion and preserve conversion errors. Add regression and boundary controls across regex/literal/Chimera, and document the accepted range.
Original source: 21 failures/18 controls; all 39 parameter cases pass afterward. Standalone full debug suites retain the existing Unicode lifetime failure addressed by #265: Python 3.12 has 70 passes/2 skips/1 failure; free-threaded 3.14 has 69 passes/3 skips/1 failure. Private eight-fix integration resolves two overlapping #265 hunks and passes 175 tests/2 skips on Python 3.9 and 174 tests/3 skips on free-threaded 3.14. Formatting, source lint and strict docs pass. Independent branch from main.