Repository navigation
Allocate scratch space when loading databases - #268
Open
sricharanreddycheruku wants to merge 1 commit into
Open
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloaded databases have no scratch space, so scanning raises InvalidError.
Allocate Scratch after deserialization, with alloc_scratch=False for callers
managing scratch manually, as suggested in the issue. Clean failed loads,
update types/docs and remove the workaround from scan tests.
Fixes #153.
Three existing scan cases fail before the fix; six allocation-option cases
reject the new argument. Three invalid-input controls pass. All twelve pass
afterward. Source-built Python 3.12: 41 pass/two slow skips. Debug suites on
3.10/3.12/3.14: 40 pass/three skips each, including the existing UTF-8 compiler
limitation. Combined with #265/#266: 96 pass/two skips under PYTHONMALLOC=debug.
clang-format 9, source Black/Ruff, changed-test formatting and strict docs pass.
Whole-test Ruff retains an unrelated unused test_text variable. Python 3.9
has an unchanged Py_NewRef build failure and was not validated. Independent
branch from main.