Explicit strategy on Multi::fromEmbedded() - #135
Merged
Merged
Conversation
The inherited IPv6 implementation rebuilt the instance without the strategy, so a non-default strategy packed the address but the result reported as version 6.
zanbaldwin
force-pushed
the
z/multi-from-embedded
branch
from
September 16, 2026 12:22
b55ca89 to
8d7187d
Compare
Greptile SummaryNo issues found. T-Rex validation blockedThe focused PHP validation could not run because no PHP executable is available in this environment. Confidence Score: 5/5Safe to merge; no confirmed issue affects the updated strategy-preservation behavior. No confirmed findings were identified. Files Needing Attention: None.
|
| Filename | Overview |
|---|---|
| src/Version/Multi.php | Forwards an optional embedding strategy through both fromEmbedded() parsing paths. |
| tests/Version/MultiTest.php | Adds regression coverage for fromEmbedded() with an explicit Derived strategy. |
| CHANGELOG.md | Documents preservation of explicitly supplied embedding strategies. |
Reviews (1): Last reviewed commit: b55ca89 | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.