Skip to content

Explicit strategy on Multi::fromEmbedded() - #135

Merged
zanbaldwin merged 1 commit into
6.xfrom
z/multi-from-embedded
Sep 16, 2026
Merged

zanbaldwin merged 1 commit into
6.xfrom
z/multi-from-embedded

Conversation

@zanbaldwin

Copy link
Copy Markdown
Member

No description provided.

@zanbaldwin zanbaldwin self-assigned this Sep 16, 2026
The inherited IPv6 implementation rebuilt the instance without the strategy, so a non-default strategy packed the address but the result reported as version 6.
@zanbaldwin
zanbaldwin force-pushed the z/multi-from-embedded branch from b55ca89 to 8d7187d Compare September 16, 2026 12:22
@zanbaldwin
zanbaldwin merged commit 41b1f00 into 6.x Sep 16, 2026
24 checks passed
@zanbaldwin
zanbaldwin deleted the z/multi-from-embedded branch September 16, 2026 12:24
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

Greptile Summary

No issues found.

T-Rex validation blocked

The focused PHP validation could not run because no PHP executable is available in this environment.

Confidence Score: 5/5

Safe to merge; no confirmed issue affects the updated strategy-preservation behavior.

No confirmed findings were identified.

Files Needing Attention: None.

T-Rex T-Rex Logs

What T-Rex did

  • A focused executable was prepared to exercise Multi::fromEmbedded() with a Derived strategy for IPv4 input and a 16-byte binary fallback, and it was run from the repository root but exited with code 127 because PHP is unavailable in this environment; the implementation capture shows that the supplied strategy is forwarded to both tryFromProtocol() and fromBinary() paths.
  • T-Rex completed the requested verification, but its local artifact references were not uploaded.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed
Filename Overview
src/Version/Multi.php Forwards an optional embedding strategy through both fromEmbedded() parsing paths.
tests/Version/MultiTest.php Adds regression coverage for fromEmbedded() with an explicit Derived strategy.
CHANGELOG.md Documents preservation of explicitly supplied embedding strategies.

Reviews (1): Last reviewed commit: b55ca89 | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant