Repository navigation
Fix data type case after keyword column names. - #421
Open
CRISvsGAME wants to merge 1 commit into
Open
CRISvsGAME wants to merge 1 commit into
CRISvsGAME wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix data type case formatting when a
CREATE TABLEcolumn name is also a known keyword.For example:
With the default lowercase type case, the data types were left unchanged because the preceding column names were still recognized as keywords during type formatting.
The fix preserves the column context while processing the following recognized data type, without weakening keyword or type detection globally. It applies generically to data types handled by pgFormatter's existing type detection rather than to any specific type such as
VARCHAR.Regression coverage includes:
VARCHARSETtype suppression withDOUBLE PRECISIONDATEfollowed by a typed default as a controlCREATE UNLOGGED TABLEUUIDowner INTfixture that exposed the same issueValidation:
prove -Ilib t/*.t— 96 tests passedperl t/regress_test.pl— 284 fixtures passed