fix: pass user-defined env vars to daprd in multi-app run - #1699
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
GetAppCommand passed config.getEnv() to the app process, but GetDaprCommand never set cmd.Env at all, so env vars set under an app's env key in dapr.yaml never reached the daprd sidecar. This meant the local env secret store, which reads from the sidecar process environment, could never see them. Pass the same user-defined env vars to daprd so the secret store can read them. Fixes dapr#1361 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetAppCommand passed config.getEnv() to the app process, but GetDaprCommand never set cmd.Env at all, so env vars set under an app's env key in dapr.yaml never reached the daprd sidecar. This meant the local env secret store, which reads from the sidecar process environment, could never see them. This passes the same user-defined env vars to daprd so the secret store can read them.
Issue reference
Please reference the issue this PR will close: #1361
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: