invoke: add --header flag for custom HTTP headers - #1698
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
There was no way to send custom HTTP headers to the target app, only the hardcoded Content-Type. Add a repeatable --header/-H flag in Key=Value form, parsed into an http.Header and threaded through Invoke() down to the outgoing request. A prior attempt at this (dapr#1287) stalled on an unrelated dependency bump, not on the feature itself, so this keeps the same flag shape and only touches invoke plumbing. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapr invokehad no way to send custom HTTP headers to the target app; onlyContent-Type: application/jsonwas ever set. This PR adds a repeatable--header/-Hflag inKey=Valueform, parsed into anhttp.Headerand threaded throughStandalone.Invoke()down to the outgoing request. A prior attempt at this (#1287) stalled on an unrelated dependency bump requested in review, not on the feature itself, so this keeps the same flag shape and scopes the change to invoke plumbing only.Issue reference
Please reference the issue this PR will close: #1286
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Notes:
go build ..TestInvokeWithHeadersinpkg/standalone/invoke_test.go, asserting a header passed toInvoke()reaches the outgoing request. Updated the four existingTestInvokecall sites for the newInvoke()parameter. Also manually verifieddapr invoke --header "Foo=Bar"and theKey=Valueformat validation on the built binary.go test ./pkg/...(the scope ofmake test) passes.--headerexample to the command's own--helpoutput (inExample); no separate docs.dapr.io page exists for individual invoke flags to extend.