feat: support envFile in multi-app run template - #1695
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Add an envFile field to the run config so apps can load environment variables from a file instead of listing them all inline under env. Values from env still win on key conflicts. Closes dapr#1369 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The multi app run template file only supports environment variables listed inline under an
envmap for each app. This PR adds anenvFilefield so an app can instead point at a file ofKEY=VALUElines (blank lines and lines starting with#are ignored). Values are merged into the app's environment during config validation; if a key exists in bothenvandenvFile, the inlineenvvalue wins.Issue reference
Please reference the issue this PR will close: #1369
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Notes:
go build ./pkg/standalone/...andgo vet ./pkg/standalone/....envmap. Full package test suite passes.