Repository navigation
Conversation
- replace cmocka asserts with standard asserts which are more practicall when trying to pin-point where a problem happened in a regular application in contrast to a test. - do not generate random OIDs/dkeys/akeys for every update. Instead, generate a set of OIDs and keys and for every update pick a random subset of them. This change increases an average branching factor for the resulting VOS tree. - allow vos_obj_update_ex() to fail with -DER_NO_PERM. This indicates the value already exists and it is of a different type compared to the one you attempt to set right now. This kind of update is not supported. dlck_test_helper allows this to happen to keep the bookkeeping required to avoid this kind of situationminimal. - fix dtx_update() so it behaves nicely for both keep_act == false and keep_act == true. - move argument parsing to a dedicate compilation unit - allow to provide --oids_num, --keys_num and --updates_num from the command line. - set default values to keep the VOS tree minmal but interesting enough for testing. Skip-func-vm: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'dlck: refine dlck_test_helper so it produduces contents which is suitable for testing purposes' |
Nasf-Fan
requested changes
Oct 30, 2026
| if (rc == -DER_NO_PERM) { | ||
| /** Current implementation does not track already used paths so the same path may be | ||
| * reused with a different data type which is not allowed. */ | ||
| return; |
Contributor
There was a problem hiding this comment.
Please dtx_end() before return.
| rc = parse_unsigned(arg, &args->oids_num, state); | ||
| break; | ||
| case KEY_WORKLOAD_KEYS_NUM: | ||
| rc = parse_unsigned(arg, &args->keys_num, state); |
Contributor
There was a problem hiding this comment.
What will happen if keys_num is zero?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-el-9.6-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-hw-test: true
Steps for the author:
After all prior steps are complete: