[knard38]

Description

This is PR 1 of 10 in the split of #18557 (see ckochhof/dev/master/daos-18626/patch-001 for the original, unsplit commit). It adds the build-system plumbing needed to compile DAOS with UndefinedBehaviorSanitizer and ThreadSanitizer, in addition to the already-supported AddressSanitizer. It does not add any CI wiring or test-runner changes — those land in later PRs in this stack.

What/why

• site_scons/site_tools/compiler_setup.py: link the UBSan/TSan runtime libraries (-lubsan/-ltsan) explicitly, including into CGO_LDFLAGS so that go build picks them up when CGO-linking a sanitizer-compiled C archive (otherwise Go binaries get "DSO missing from command line" for libubsan.so.1).
• src/control/SConscript: skip control man-page generation under a SANITIZERS build (not needed, avoids extra build cost).
• src/gurt/misc.c: skip d_free()'s debug poisoning memset() under TSan, which otherwise turns a harmless zero-size-allocation address reuse into a false heap-use-after-free report (confirmed via an isolated single-threaded reproducer to be a TSan tool limitation, not a DAOS bug).
• utils/scripts/install-el9.sh: install compiler-rt, libubsan, and libtsan alongside the existing libasan dependency.
• utils/docker/Dockerfile.el.9: thread a new SANITIZERS build-arg through to the scons invocation (empty/unset by default, so existing callers are unaffected).

This is purely additive: no existing (non-sanitizer) build is affected, and SANITIZERS=address behavior is unchanged.

Steps for the author:

• Commit message follows the guidelines.
• Appropriate Features or Test-tag pragmas were used.
• Appropriate Functional Test Stages were run.
• At least two positive code reviews including at least one code owner from each category referenced in the PR.
• Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

• Gatekeeper requested (daos-gatekeeper added as a reviewer).

[github-actions]

Ticket title is 'Add ASan/UBSan/TSan sanitizer checks to the GitHub Actions unit-test CI'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18626

[daosbuild3]

Test stage Test RPMs on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18613/2/execution/node/1314/log

[knard38]

@grom72, @daltonbohning and @phender could you have a look at this PR please.
Thanks in advance.

[daosbuild3]

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18613/8/testReport/

[kjacque]

Basically looks OK, I think it's worthwhile to update the confusing name in the build scripts though.

[knard38]

@daos-stack/daos-gatekeeper could you lend this PR with the following commit message:

• title: DAOS-18626 build: Add ASan/UBSan/TSan compiler and Docker build support
• body:

Add scons support for building DAOS with the AddressSanitizer,
UndefinedBehaviorSanitizer, and ThreadSanitizer compiler
instrumentation, and plumb SANITIZERS through to the Docker EL9
build image and its package list.

SANITIZERS now uses the token 'undefined_behavior' instead of the
compiler's own 'undefined' for the UBSan case, since the latter reads
as "value not set". A translation map converts it back to the real
-fsanitize= flag wherever a sanitizer flag is built or removed. The
UBSan/TSan runtime libraries are also linked explicitly (-lubsan,
-ltsan) and injected into CGO_LDFLAGS, since GCC only auto-links them
for pure-C targets and CGO would otherwise fail to link Go binaries
with "DSO missing from command line".

Two sanitizer-specific workarounds are included: d_free() now skips
its 0x42 memory-poisoning under TSan, since that otherwise turns
harmless zero-size-allocation address reuse into a false
heap-use-after-free; and the control man-page generation step, which
runs the just-built binary, is skipped when SANITIZERS is set to
avoid tripping sanitizer false positives during the build itself.

install-el9.sh and the EL9 Dockerfile gain the libasan/libubsan/
libtsan/compiler-rt packages and a SANITIZERS Docker build arg.