Skip to content

Avoid duplicate config entry reloads and fix update-listener warning - #72

Merged
dala318 merged 1 commit into
dala318:mainfrom
hmmbob:fix/poollab-update-listener
Nov 2, 2026
Merged

dala318 merged 1 commit into
dala318:mainfrom
hmmbob:fix/poollab-update-listener

Conversation

@hmmbob

@hmmbob hmmbob commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Reconfiguring PoolLab schedules a reload through both its update listener and async_update_reload_and_abort. Home Assistant warns that this combination stops working in 2026.12. Reauthentication can likewise reload twice because it updates the entry and then explicitly reloads it.

Remove the redundant update listener and its callback. Both config-flow paths already perform the required reload, including when credentials are unchanged. This follows the documented option to retain config-flow reloads and remove the listener, and avoids requiring a newer config-flow helper.

Validation:

Fixes #68.

Reference: https://developers.home-assistant.io/blog/2026/05/07/config-entry-listener-together-with-reloading-methods/

No polling, timeout, sensor-write or error-message changes are included; the patch attached to #69 does not address this reload issue. The existing Hassfest translation failure and test collection compatibility issue are handled separately in #71.

schford added a commit to schford/python_poollab that referenced this pull request Oct 22, 2026
@dala318
dala318 merged commit 010f6e9 into dala318:main Nov 2, 2026
2 of 3 checks passed
@hmmbob
hmmbob deleted the fix/poollab-update-listener branch November 2, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Listener

2 participants