Repository navigation
update: optimize broadcaster by lazily computing cert entry bytes - #128
Merged
d-Rickyy-b merged 6 commits intoSep 27, 2026
Merged
Conversation
Merge changes for 1.10 into master branch
Fix bug in kafka implementation that caused double client registration
d-Rickyy-b
requested changes
Sep 25, 2026
d-Rickyy-b
left a comment
d-Rickyy-b
left a comment
Owner
There was a problem hiding this comment.
Sorry for the inconvenience but could you please recreate the PR towards the dev branch? I am trying to keep unpublished changes in dev and have master/main on the latest published version or release candidate.
Also see the comment regarding the implementation.
Contributor
|
I plan to do something similar, but much different |
d-Rickyy-b
reviewed
Sep 26, 2026
| } | ||
|
|
||
| func entryBytesComputer(entry *models.Entry) func(subType SubscriptionType) ([]byte, error) { | ||
| return func(subType SubscriptionType) ([]byte, error) { |
Owner
There was a problem hiding this comment.
What's the benefit of using a closure here instead of just keeping the switch/case statement as before? I currently only see one additional function call instead of having the switch/case directly within the loop.
Contributor
Author
There was a problem hiding this comment.
Ah silly me, took care of it now.
d-Rickyy-b
approved these changes
Sep 27, 2026
Contributor
|
@d-Rickyy-b shouldn't this PR have been squashed before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimise broadcaster by lazily computing cert entry bytes