Repository navigation
refactor(locallibrary): state what edit and profile lookups can't miss - #457
Merged
Merged
Conversation
These branches can't run, so they hid the reason they can't. Say it with expect, or drop the check where nothing can reach it.
bnb
approved these changes
Nov 5, 2026
Rust coverageFrom run 366. Both are held to the thresholds in .cargo/config.toml.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces fallbacks that can't run with
expectcalls that say why, so a reader doesn't have to work out what the quiet branch was for and coverage stops counting code nothing can reach. None of these changes what any input does.Changed
Op::RenameandOp::SetEntriesinedit.rsupdate the playlistfind_nodejust found withexpect.find_nodewalkslib.playlists, and noEditDbremoves a playlist inrenameorset_entries.list(spec).expect_err(..).foundis the same lookup aslist(find_playlist_of_kindandat_recorded_path), solistcan't succeed there.Files::locateinprofile/mod.rstakes the store withexpectforOrigin::Snapshot. Both places that make one are insideif let Some(store) = sources.store, andFiles::storeis that same store.styleinprofile/mod.rstakes each setting's definition withexpect.describeis only called withSTYLE_SETTINGSkeys.Added
every_style_setting_is_a_setting, so renaming one of those settings in the schema fails a test rather than panicking instyle.Removed
plan.is_noop()check inreplay_set_path. A strict plan of oneEdit::SetPaththat comes backOkalways holds anOp::SetPath, whichis_noopcounts as a change.