Repository navigation
fix(locallibrary): move every row's entries when replacing a shared file's track - #452
Merged
Merged
Conversation
…ile's track Op::Repoint moved the playlist and history entries of one row of the duplicate's file, but replacing a track deletes every row of that file, so the other rows' entries went with them.
github-actions
Bot
added
documentation
bnb
approved these changes
Nov 5, 2026
Rust coverageFrom run 356. Both are held to the thresholds in .cargo/config.toml.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a track deletes every row of the duplicate's audio file, but the repoint operation before it moved the playlist and history entries of only one of those rows. When a second row of the file sat in a list (rekordbox's own export can do this), its entries were lost with the delete.
Changed
Op::Repointmoves the entries of every row of the file it names to the kept track, inexport.pdb,exportLibrary.dband the model.Added
Removed
Nothing.