[botandbang]

What and why

Fixes LOC-173.

On a Mac, 14 of 62 end-to-end tests failed on main in the WebKit and iPhone projects. There were five causes, one of them in the app.

The tools panel moved. each tool shows itself at work says picking a cue moves nothing on the page. On an iPhone 14 the panel went from 799.97 px to 827.86 px picking another cue, after fonts had settled. HotCues.svelte gave the capture a fixed stage but sized the words to the selected cue. A cue whose line wraps to one more line pushed everything below it.

Scripts held back meant no load. beforeHydration holds the page's scripts, then calls page.goto, which waits for load. WebKit on macOS holds load for those scripts, so 8 failures were a 60 s timeout there. Waiting for domcontentloaded is what the helper needs.

Clicks before hydration. WebKit fires load without waiting for the app's module imports, and on the dev server each module is a request of its own. A click could reach a use:enhance form or a link before any script took it over, and leaving the page cancelled the imports (TypeError: Importing a module script failed), after which SvelteKit's fallback sent the browser back. This is the Verify chain, Ask for access and Manage failures. The file already had the signal, data-hydrated, so there's now one hydrated(page) helper, used before the first click after a navigation.

An approval that outlives sign-out. Since d0e3acf, sign-in keeps optional scopes an account held. Every project runs against the same network, so once one browser approved posting as pat.test, the next never saw Approve posting first. The test makes its own account.

A table on a desktop, cards on a phone. The verification test found its row by the row role, which a phone's list of cards doesn't have.

Added

• hydrated(page) in app.e2e.ts.

Changed

• HotCues.svelte puts every cue's words in one grid cell, the others invisible, so the cell is as tall as the longest, and hidden words stay out of the accessibility tree.
• beforeHydration waits for domcontentloaded.
• hydrated(page) replaces the file's repeated data-hydrated assertion and runs before each first click after a navigation.
• The report test makes an account per run and browser through the PDS's createAccount.
• The verification test finds the entry as a row or a list item.

Removed

• const cue in HotCues.svelte, which nothing else used.

How it was tested

On macOS with Playwright's WebKit:

• main: 14 failed, 48 passed in WebKit and iPhone, in 17.0 minutes.
• This branch, Chromium, WebKit, Android and iPhone: 124 passed.
• This branch, WebKit and iPhone again on a fresh network: 62 passed in 9.6 minutes.
• pnpm check has 0 errors, and pnpm test passed 2,047 tests.

pnpm test:coverage (2,395 passed, 5 skipped), main against this branch, in percent:

	thresholds	main	this branch
statements	97.1	97.15	97.16
branches	91.8	91.92	91.92
functions	96.5	96.64	96.66
lines	98.1	98.16	98.16
HotCues.svelte branches		82.92	83.33

HotCues.svelte stays at 100% of lines.

Firefox can't start in the environment I ran this in (Could not find profile folder, before any app code runs), so Firefox hasn't run these changes. The scheduled workflow will. --repeat-each 2 passed 121 of 124: a DJ proposes a change uses one tagline per project, so a second pass on the same network collides with the first. The tests are meant for one pass per network.

[linear-code]

LOC-173

[github-actions]

Coverage Report for apps/web

Status	Category	Percentage	Covered / Total
🟢	Lines	98.16% (🎯 98%) 🟰 ±0 pp	10228 / 10419
🟢	Statements	97.15% (🎯 97%) 🟰 ±0 pp	15519 / 15973
🟢	Functions	96.64% (🎯 96%) 🟰 ±0 pp	4118 / 4261
🟢	Branches	91.93% (🎯 91%) 🟰 ±0 pp	7512 / 8171

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
apps/web/src/lib/components/tools/HotCues.svelte	99.47% ⬆️ +0.01 pp	83.33% ⬆️ +0.41 pp	98.36% ⬆️ +0.06 pp	100% 🟰 ±0 pp	145

Generated in workflow #351 for commit 02d0578 by the Vitest Coverage Report Action

Size

Compared with main. KiB are 1,024 bytes.

	This pull request	main	Change
Client JavaScript	771.5 KiB	771.3 KiB	+121 B (+0%)
Client JavaScript, brotli	259.3 KiB	259.3 KiB	-9 B (-0%)
Client CSS	94.5 KiB	94.5 KiB	0 B (0%)
Client CSS, brotli	13.6 KiB	13.6 KiB	0 B (0%)