Repository navigation
ci: rebase the docs deploy onto gh-pages instead of force-pushing [ENG-1736] - #63
Merged
Merged
Conversation
…G-1736] release-0.8 now deploys its docs to 0.8/docs on the same gh-pages branch, and chart-releaser pushes index.yaml there. The deploy action force-pushes by default, so a deploy that started before one of those and pushed after it would drop its commit. A concurrency group per branch keeps main's own deploys in order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhM4wHR2xPP8bbrkXGaqUD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops
main's docs deploy from force-pushing overgh-pages(ENG-1736).gh-pagesis about to receive pushes from three places:main's docs deploy, todocs/;release-0.8's docs deploy, to0.8/docs(docs: publish the 0.8 docs under 0.8/docs, pinned to chart 0.8.1 [ENG-1736] #62);index.yaml.JamesIves/github-pages-deploy-actionforce-pushes by default. A deploy that checks outgh-pages, then pushes after one of the others, drops the other's commit:0.8/docsreverts, or a new chart version disappears fromindex.yaml.Changes
force: false: the action rebases its commit onto the currentgh-pagesinstead.sync-docs-${{ github.ref }}: keepsmain's own deploys in order. A queued deploy can be dropped, because the next one carries every earlier change.There's deliberately no group shared with
release-0.8. GitHub keeps one pending run per group and cancels the older one, which would silently drop the other branch's deploy.#62 makes the same change on
release-0.8. Merge this one before or with it.Testing
force: falseand the concurrency group in place.main.🤖 Generated with Claude Code
https://claude.ai/code/session_01UhM4wHR2xPP8bbrkXGaqUD
Need help on this PR? Tag
@codesmith-botwith what you need.